REF: use astype_array instead of astype_nansafe #50222
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
added
Refactor
phofl
approved these changes
Dec 16, 2022
mroeschke
approved these changes
Dec 17, 2022
|
Thanks @jbrockmendel |
phofl
pushed a commit
to phofl/pandas
that referenced
this pull request
Dec 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to ensure we have only one astype behavior.
The BaseParser change could change behavior if we can get there with dt64/td64 data (that includes at least one NaT) and an integer dtype, but we don't have any test cases that get there with dt64/td64 and it isn't clear to me if it is possible. If it is, the non-raising behavior here is more consistent with our other behavior.