Skip to content

REF: de-duplicate period-dispatch #50215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 13, 2022
Merged

REF: de-duplicate period-dispatch #50215

merged 3 commits into from
Dec 13, 2022

Conversation

jbrockmendel
Copy link
Member

@phofl you should be able to re-use with _accumulate to fix the PeriodDtype-with-Nat case

phofl
phofl reviewed Dec 12, 2022
View reviewed changes
Copy link
Member

@phofl phofl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@mroeschke mroeschke added the Refactor Internal refactoring of code label Dec 13, 2022
@mroeschke
Copy link
Member 

pandas/core/arrays/datetimelike.py:1554: error: Untyped decorator makes function "_quantile" untyped  [misc]
pandas/core/arrays/datetimelike.py:1562: error: Untyped decorator makes function "min" untyped  [misc]
pandas/core/arrays/datetimelike.py:1580: error: Untyped decorator makes function "max" untyped  [misc]
pandas/core/arrays/datetimelike.py:1635: error: Untyped decorator makes function "median" untyped  [misc]

@mroeschke mroeschke added this to the 2.0 milestone Dec 13, 2022
@mroeschke mroeschke merged commit e0b93cc into pandas-dev:main Dec 13, 2022
@mroeschke
Copy link
Member

Thanks @jbrockmendel

@jbrockmendel jbrockmendel deleted the ref-period_dispatch branch December 13, 2022 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phofl phofl phofl left review comments

@mroeschke mroeschke mroeschke approved these changes

Assignees
No one assigned
Labels
Refactor Internal refactoring of code
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@jbrockmendel @mroeschke @phofl