Skip to content

CLN: Remove unsupported skips of pyarrow versions #50208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 12, 2022
Merged

Conversation

phofl
Copy link
Member

@phofl phofl commented Dec 12, 2022

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

@phofl phofl added the Clean label Dec 12, 2022
Copy link
Member

@mroeschke mroeschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Merge on green.

As an aside, would be cool if skip_if_no could just use pandas.compat._optional.VERSIONS for the minimums

@mroeschke mroeschke added this to the 2.0 milestone Dec 12, 2022
@phofl phofl merged commit 5ee4dac into pandas-dev:main Dec 12, 2022
@phofl phofl deleted the pyarrow branch December 12, 2022 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants