BUG/TST Added support for empty dictionary when passed to agg for gro… #50192
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…upby This adds consistency across empty containers when passed to agg for groupby. Also added new test to check new functionality works as expected.
mroeschke
reviewed
Dec 13, 2022
| # empty list and tuple | ||
| from pandas import DataFrame | ||
|
|
||
| result = DataFrame() |
There was a problem hiding this comment.
Does type(selected_object)() work here?
rhshadrach
reviewed
Dec 13, 2022
|
|
||
|
|
||
| def test_empty_container_consistency(): | ||
| df = DataFrame(data={"a": [1, 2], "b": [3, 4], "c": [5, 6]}) |
There was a problem hiding this comment.
Can you add the GitHub Issue number as a comment in the first line
Comment on lines
+417
to
+420
| # GH 48581 - Adding consistency to empty agg types | ||
| if not results: | ||
| # return empty DataFrame if results is empty, following pattern | ||
| # empty list and tuple |
There was a problem hiding this comment.
I think the comments here can be removed; I think it's clear that the else code path will fail in this case and why we're returning an empty frame.
|
This pull request is stale because it has been open for thirty days with no activity. Please update and respond to this comment if you're still interested in working on this. |
|
Thanks for the pull request, but it appears to have gone stale. If interested in continuing, please merge in the main branch, address any review comments and/or failing tests, and we can reopen. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…upby
This adds consistency across empty containers when passed to agg for groupby. Also added new test to check new functionality works as expected.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.