BUG: Fix a bug when indexing np.nan via loc/iloc (GH5016) #5018
+101
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if not key in ax: | ||
| error() | ||
| except (TypeError) as e1: | ||
| if str(e1).startswith('unorderable'): |
There was a problem hiding this comment.
@jtratner I had to do this to convert the TypeError (because in py3 it raises differently in 2), is there a 'better' way to detect this?
There was a problem hiding this comment.
this is a Python 2/Python 3 difference.
None < 5 is True in Python 2, but is a TypeError in Python 3.
There was a problem hiding this comment.
why not make a subclass of typeerror and just catch the different instances how you wnat to
There was a problem hiding this comment.
I want to pass type errors upward but as u noticed above the comparison raises in py3 but not in 2
not so easy to trap the type error on the cases that we want
jreback
added a commit
that referenced
this pull request
Sep 28, 2013
BUG: Fix a bug when indexing np.nan via loc/iloc (GH5016)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #5016