Skip to content

CI: remove aiobotocore pin #50158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

jorisvandenbossche
Copy link
Member

@jorisvandenbossche jorisvandenbossche commented Dec 9, 2022

Closes #44311

@jorisvandenbossche jorisvandenbossche added the CI Continuous Integration label Dec 9, 2022
@jorisvandenbossche
Copy link
Member Author

The doc build is passing.

Copy link
Member

@phofl phofl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this does not actually remove the pin from environment.yml. Was this on purpose?

@jorisvandenbossche
Copy link
Member Author

Hmm, not sure what went wrong there ;)

@phofl
Copy link
Member

phofl commented Dec 11, 2022

This is odd, but the install requirements failure is legit. Installing asv==0.5.0 locally with pip is failing as well. Not sure why we are pulling an older version here

@jorisvandenbossche
Copy link
Member Author

But the strange thing is that it is not failing on main? maybe some pip cache related issue?

@jorisvandenbossche
Copy link
Member Author

It doesn't explain why it starts to happen now, but we should probably pin to 0.5.1 since that fixed the issue with requirements-dev.txt: airspeed-velocity/asv@516e283

@phofl phofl added this to the 2.0 milestone Dec 17, 2022
@phofl phofl merged commit 47514cf into pandas-dev:main Dec 17, 2022
@phofl
Copy link
Member

phofl commented Dec 17, 2022

thx @jorisvandenbossche

@jorisvandenbossche jorisvandenbossche deleted the environment-remove-aiobotocore branch December 17, 2022 20:17
phofl pushed a commit to phofl/pandas that referenced this pull request Dec 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI/DOC/DEPS: Unpin aiobotocore in environment.yml for failing doc build
2 participants