Skip to content

DOC: BT for VisualStudio2022 #50144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 10, 2022
Merged

Conversation

natmokval
Copy link
Contributor

The set of components is the same as with UI installation.

Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for working on this @natmokval !

Comment on lines 48 to 49
You can install the necessary components on the commandline using
`vs_buildtools.exe <https://download.visualstudio.microsoft.com/download/pr/9a26f37e-6001-429b-a5db-c5455b93953c/460d80ab276046de2455a4115cc4e2f1e6529c9e6cb99501844ecafd16c619c4/vs_BuildTools.exe>`_:
`vs_buildtools.exe <https://download.visualstudio.microsoft.com/download/pr/f3f8db49-2cd0-43df-9ced-12dcb6b3954b/1a327074f0b07f951467739a34f07c5db6b491aa5df2ed3e4054759ceb1c994d/vs_BuildTools.exe>`_:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this an alternative to the above? If so, how did you find the instructions, are they referenced somewhere? Just wondering if there's a link we could put instead, and this section is long (and will be hard to keep up-to-date)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it's OK to just link to https://learn.microsoft.com/en-us/visualstudio/install/use-command-line-parameters-to-install-visual-studio?source=recommendations&view=vs-2022?

Something like

Alternatively, you can install the necessary components on the commandline use `vs_BuildTools.exe <https://learn.microsoft.com/en-us/visualstudio/install/use-command-line-parameters-to-install-visual-studio?source=recommendations&view=vs-2022>`_

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it is the new link to BuildTools for VisualStudio2022.

The instructions for installation are described at the link referenced above in the documentation. I received the detailed link by resolving the link behind Download button. The shorter form of the same link is https://aka.ms/vs/17/release/vs_BuildTools.exe. But I don't know which link will exist longer.

Agreed, I am not sure if we need to keep detailed instructions for the installation of the necessary components by using command-line.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool, let's remove then, if anyone wants to do it all via the command-line for some reason I think we can leave it to them to figure out - thanks for trying it out though!

Comment on lines 39 to 40
You will need `Build Tools for Visual Studio 2022
<https://visualstudio.microsoft.com/downloads/>`_.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we can link directly to BuildTools for VisualStudio2022.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we link directly, do we still need the below part of the instruction for installing a C compiler for Windows?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as in, the warning "You DO NOT need to install Visual Studio 2022"?

might still be best to keep it, in case someone scrolls away from the exact location the link above

we could change it to .. note:: though, "warning" doesn't really reflect the severity of the paragraph 😄

@MarcoGorelli MarcoGorelli added this to the 2.0 milestone Dec 10, 2022
Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @natmokval !

@MarcoGorelli MarcoGorelli merged commit eedcb5f into pandas-dev:main Dec 10, 2022
@MarcoGorelli
Copy link
Member

@meeseeksdev please backport to 1.5.x

meeseeksmachine pushed a commit to meeseeksmachine/pandas that referenced this pull request Dec 23, 2022
MarcoGorelli pushed a commit that referenced this pull request Dec 23, 2022
…0418)

Backport PR #50144: DOC: BT for VisualStudio2022

Co-authored-by: Natalia Mokeeva <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DOC: Creating development environment - BT for Visual Studio version
2 participants