Skip to content

CI fix Code Checks install Python #50110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 7, 2022

Conversation

MarcoGorelli
Copy link
Member

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

@MarcoGorelli
Copy link
Member Author

MarcoGorelli commented Dec 7, 2022

@mroeschke this seems to have fixed the issue (before we had Code Checks / pre-commit (pull_request) Failing after 9s ) - we OK to do a quick merge so other PRs can be rebased?

https://github.com/pandas-dev/pandas/actions/runs/3641673645/jobs/6147888941

@MarcoGorelli MarcoGorelli changed the title CI try fixing actions CI fix Code Checks setup-python Dec 7, 2022
@MarcoGorelli MarcoGorelli changed the title CI fix Code Checks setup-python CI fix Code Checks install Python Dec 7, 2022
@MarcoGorelli MarcoGorelli added the CI Continuous Integration label Dec 7, 2022
@mroeschke
Copy link
Member

Sure, but I Imagine this will need to be backported?

@MarcoGorelli MarcoGorelli added this to the 1.5.3 milestone Dec 7, 2022
@MarcoGorelli
Copy link
Member Author

yeah you're right

@MarcoGorelli MarcoGorelli merged commit 3af7170 into pandas-dev:main Dec 7, 2022
@lumberbot-app
Copy link

lumberbot-app bot commented Dec 7, 2022

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout 1.5.x
git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 3af7170292e579413b84424448fc98bd13dffd09
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #50110: CI fix Code Checks install Python'
  1. Push to a named branch:
git push YOURFORK 1.5.x:auto-backport-of-pr-50110-on-1.5.x
  1. Create a PR against branch 1.5.x, I would have named this PR:

"Backport PR #50110 on branch 1.5.x (CI fix Code Checks install Python)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants