TYP: fix mypy ignored error in pandas/compat/numpy/function.py #50104
Conversation
|
|
||
| validate_argsort_kind(args, kwargs, max_fname_arg_count=3) | ||
| # error: Incompatible return value type (got "int", expected "bool") | ||
| return ascending # type: ignore[return-value] | ||
| return ascend |
There was a problem hiding this comment.
this isn't defined in the False case
There was a problem hiding this comment.
Should I remove the variable and return True instead?
There was a problem hiding this comment.
you'll need to make sure ascend is defined in the False case
|
@jbrockmendel I pushed up a change for the false case for ascend. Let me know your thoughts. |
| @@ -192,12 +192,12 @@ def validate_clip_with_axis( | |||
| args = (axis,) + args | |||
| # error: Incompatible types in assignment (expression has type "None", | |||
| # variable has type "Union[ndarray[Any, Any], str, int]") | |||
| axis = None # type: ignore[assignment] | |||
| axes = None # type: ignore[assignment] | |||
There was a problem hiding this comment.
same thing here, you need to make srue axes is defined in the other case
|
try running the test suite locally before pushing. itll help identify problems with a faster turnaround |
|
Got it. Thanks! |
|
This pull request is stale because it has been open for thirty days with no activity. Please update and respond to this comment if you're still interested in working on this. |
|
Thanks for the pull request, but it appears to have gone stale. If interested in continuing, please merge in the main branch, address any review comments and/or failing tests, and we can reopen. |
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.