Skip to content

REGR: memory_usage showing unnecessary FutureWarning #50068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Dec 8, 2022

Conversation

phofl
Copy link
Member

@phofl phofl commented Dec 5, 2022

@phofl phofl added the Regression Functionality that used to work in a prior pandas version label Dec 5, 2022
@phofl phofl added this to the 1.5.3 milestone Dec 5, 2022
Copy link
Member

@rhshadrach rhshadrach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rhshadrach rhshadrach added Bug DataFrame DataFrame data structure labels Dec 5, 2022
@rhshadrach
Copy link
Member

Either need conditional logic on 32 vs 64-bit machines or just not check the result; I'm okay with the latter for this.

@phofl
Copy link
Member Author

phofl commented Dec 7, 2022

lets try intp

@rhshadrach
Copy link
Member

It's not the dtype, it's the value. You're counting bytes on 32bit vs 64bit machines.

@phofl
Copy link
Member Author

phofl commented Dec 7, 2022

Thx, should have checked the error message...

@rhshadrach rhshadrach merged commit e0b111b into pandas-dev:main Dec 8, 2022
@rhshadrach
Copy link
Member

Thanks @phofl

meeseeksmachine pushed a commit to meeseeksmachine/pandas that referenced this pull request Dec 8, 2022
@phofl phofl deleted the 50066 branch December 8, 2022 13:18
phofl added a commit to meeseeksmachine/pandas that referenced this pull request Dec 8, 2022
…ing unnecessary FutureWarning) (pandas-dev#50122)

Backport PR pandas-dev#50068: REGR: memory_usage showing unnecessary FutureWarning

Co-authored-by: Patrick Hoefler <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug DataFrame DataFrame data structure Regression Functionality that used to work in a prior pandas version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: Computing sys.getsizeof a DataFrame with no columns results in an irrelevant FutureWarning
2 participants