-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
CI: Pin pyarrow smaller than 10 #50055
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🤔 yeah, why is version 3.3.2 getting installed? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems to have solved the matplotlib issue, let's merge green-ish / soon-ish
merging to fix CI, thanks @phofl ! |
3.6.2 was pulled on main, same version as before but plotting tests were failing anyway |
are you sure? this build from main had matplotlib 3.3.2, which was causing the plotting tests to fail |
good point, checked a build where only the arrow tests were failing |
Guess: A dependency of a dependency pinned arrow recently and we pulled a really old build there that did not pin arrow but matplotlib. |
@mroeschke I think we should revisit our conversation from a while back to pin everything to be at least our minimum allowed dependency |
this needs backporting, 1.5.x CI is failing |
@meeseeksmachine backport 1.5.x |
@meeseeksdev backport to 1.5.x |
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon! Remember to remove the If these instructions are inaccurate, feel free to suggest an improvement. |
Backport PR #50055: CI: Pin pyarrow smaller than 10 Co-authored-by: Patrick Hoefler <[email protected]>
This reverts commit 4c5db2e.
lets see if this fixes ci, matplotlib is a bit weird