Skip to content

CI: Pin pyarrow smaller than 10 #50055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 4, 2022
Merged

Conversation

phofl
Copy link
Member

@phofl phofl commented Dec 4, 2022

lets see if this fixes ci, matplotlib is a bit weird

@MarcoGorelli
Copy link
Member

matplotlib is a bit weird

🤔 yeah, why is version 3.3.2 getting installed?

Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to have solved the matplotlib issue, let's merge green-ish / soon-ish

@MarcoGorelli MarcoGorelli added this to the 2.0 milestone Dec 4, 2022
@MarcoGorelli MarcoGorelli added the CI Continuous Integration label Dec 4, 2022
@MarcoGorelli
Copy link
Member

merging to fix CI, thanks @phofl !

@MarcoGorelli MarcoGorelli merged commit 4c5db2e into pandas-dev:main Dec 4, 2022
@phofl
Copy link
Member Author

phofl commented Dec 4, 2022

3.6.2 was pulled on main, same version as before but plotting tests were failing anyway

@MarcoGorelli
Copy link
Member

are you sure? this build from main had matplotlib 3.3.2, which was causing the plotting tests to fail

@phofl
Copy link
Member Author

phofl commented Dec 4, 2022

good point, checked a build where only the arrow tests were failing

@phofl
Copy link
Member Author

phofl commented Dec 4, 2022

Guess: A dependency of a dependency pinned arrow recently and we pulled a really old build there that did not pin arrow but matplotlib.

@phofl
Copy link
Member Author

phofl commented Dec 4, 2022

@mroeschke I think we should revisit our conversation from a while back to pin everything to be at least our minimum allowed dependency

@phofl phofl deleted the ci_pyrrow branch December 4, 2022 17:42
@MarcoGorelli
Copy link
Member

this needs backporting, 1.5.x CI is failing

@MarcoGorelli
Copy link
Member

@meeseeksmachine backport 1.5.x

@phofl phofl modified the milestones: 2.0, 1.5.3 Dec 7, 2022
@MarcoGorelli
Copy link
Member

@meeseeksdev backport to 1.5.x

@lumberbot-app
Copy link

lumberbot-app bot commented Dec 7, 2022

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout 1.5.x
git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 4c5db2e435d13c5ca91f98d07edde18a498ae6dd
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #50055: CI: Pin pyarrow smaller than 10'
  1. Push to a named branch:
git push YOURFORK 1.5.x:auto-backport-of-pr-50055-on-1.5.x
  1. Create a PR against branch 1.5.x, I would have named this PR:

"Backport PR #50055 on branch 1.5.x (CI: Pin pyarrow smaller than 10)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

MarcoGorelli pushed a commit to MarcoGorelli/pandas that referenced this pull request Dec 7, 2022
MarcoGorelli added a commit that referenced this pull request Dec 8, 2022
Backport PR #50055: CI: Pin pyarrow smaller than 10

Co-authored-by: Patrick Hoefler <[email protected]>
MarcoGorelli pushed a commit to MarcoGorelli/pandas that referenced this pull request Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants