ENH: maybe_convert_objects add boolean support with NA #50047
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ts_nullable_boolean # Conflicts: # pandas/_libs/lib.pyx
jbrockmendel
reviewed
Dec 3, 2022
jbrockmendel
reviewed
Dec 5, 2022
mroeschke
reviewed
Dec 8, 2022
| encountered, whether to convert and return an IntegerArray. | ||
| convert_to_nullable_dtype : bool, default False | ||
| If an array-like object contains only integer or boolean values (and NaN) is | ||
| encountered, whether to convert and return an Boolean/IntegerArray. |
There was a problem hiding this comment.
Just to confirm FloatArray isn't supported yet?
There was a problem hiding this comment.
This is something I raised in the sql pr as well. Currently, we only use ea, when the regular dtype can’t hold missing values. So there is no real use case for FloatArray.
it would probably make more sense to always convert when this flag is set, but this is out of scope here
There was a problem hiding this comment.
Yeah. I would opt to returning Float64 when people specify use_nullable_dtypes=True, especially once (hopefully) other core devs find it useful to store NaN & NA
But sure can be a follow up
mroeschke
approved these changes
Dec 8, 2022
jbrockmendel
approved these changes
Dec 9, 2022
|
thanks @phofl |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is necessary for read_sql and nullables.
I could not find a usage of
convert_to_nullable_integer, so we should be able to repurpose the keyword