Skip to content

BUG: Fix bug in maybe_convert_objects with None and nullable #50043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 3, 2022

Conversation

phofl
Copy link
Member

@phofl phofl commented Dec 3, 2022

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

I don't think that this is user visible right now. Stumbled on this when working on nullables for read_sql

@phofl phofl added Bug Dtype Conversions Unexpected or buggy dtype conversions labels Dec 3, 2022
Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm if green

@phofl phofl added this to the 2.0 milestone Dec 3, 2022
@phofl phofl merged commit 1d5ce5b into pandas-dev:main Dec 3, 2022
@phofl phofl deleted the maybe_convert_objects branch December 3, 2022 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Dtype Conversions Unexpected or buggy dtype conversions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants