Skip to content

TST: adding new test for groupby cumsum with named aggregate #50033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Dec 8, 2022
Merged

TST: adding new test for groupby cumsum with named aggregate #50033

merged 8 commits into from
Dec 8, 2022

Conversation

seanjedi
Copy link
Contributor

@seanjedi seanjedi commented Dec 3, 2022 •
edited
Loading

@seanjedi seanjedi mentioned this pull request Dec 3, 2022
Closed
3 tasks
@rhshadrach rhshadrach added Groupby Needs Tests Unit test(s) needed to prevent regressions Apply Apply, Aggregate, Transform, Map Timedelta Timedelta data type labels Dec 3, 2022
@rhshadrach rhshadrach changed the title test: adding new test for groupby cumsum with named aggregate TST: adding new test for groupby cumsum with named aggregate Dec 3, 2022
@seanjedi seanjedi marked this pull request as ready for review December 3, 2022 23:06
rhshadrach
rhshadrach requested changes Dec 5, 2022
View reviewed changes
Copy link
Member

@rhshadrach rhshadrach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Some requests below. In general, you don't need to use the exact code that's in the issue; it's best to clean up and simplify the example in the issue when possible.

@seanjedi seanjedi requested a review from rhshadrach December 6, 2022 02:20
rhshadrach
rhshadrach requested changes Dec 6, 2022
View reviewed changes
@seanjedi seanjedi requested a review from rhshadrach December 7, 2022 00:01
rhshadrach
rhshadrach approved these changes Dec 8, 2022
View reviewed changes
Copy link
Member

@rhshadrach rhshadrach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rhshadrach rhshadrach added this to the 2.0 milestone Dec 8, 2022
@rhshadrach rhshadrach merged commit 3ece807 into pandas-dev:main Dec 8, 2022
@rhshadrach
Copy link
Member

Thanks @seanjedi!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhshadrach rhshadrach rhshadrach approved these changes

Assignees
No one assigned
Labels
Apply Apply, Aggregate, Transform, Map Groupby Needs Tests Unit test(s) needed to prevent regressions Timedelta Timedelta data type
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.

BUG: not possible to 'cumsum' Timedelta with named aggregation
2 participants
@seanjedi @rhshadrach