-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
DOC: Groupby transform should mention that parameter can be a string #50029
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…an take a string argument
…ould_mention_that_function_parameter_can_be_a_string_in_transfor
@seanjedi - thanks for the PR! Can you shorten the title (there is an edit button above) - being concise is best here. |
@seanjedi can you add examples also, |
…n_that_function_parameter_can_be_a_string_in_transfor' of https://github.com/seanjedi/pandas into SEANJEDI-49961_Docs_for_groupby_transform_should_mention_that_function_parameter_can_be_a_string_in_transfor
…ould_mention_that_function_parameter_can_be_a_string_in_transfor
@ramvikrams Responding to: #50029 (comment) Also, I have updated the code here for the example with |
I think we have to change the example also for Series it must be with pd.Series |
@ramvikrams is this better? In DataFrameGroupBy.transform it should be |
I think changing the example for series and then rewriting it completely because right now it's with pd.dataframe |
@ramvikrams Sorry, I had to update my comment, for b06287e it should be updating the template, so that: Since So I am a bit confused since that is what you wanted correct? |
I am trying to say that this example
which is there in SeriesGroupBy.transform can you also change this it should be with pd.Series not dataframe, so can you rewrite this. |
Ohh I see, I made an update here for that, hopefully, that fixes it, let me know where else I should do that change as well I see some other dataframes in the doc (IE line 467 and 484), but it is specifically saying when using transform with dataframes, so I am unsure if I should change it |
@seanjedi can you change this for the series example
|
…ould_mention_that_function_parameter_can_be_a_string_in_transfor
@ramvikrams I think this should resolve the ask that you had: 207abd6 |
…ould_mention_that_function_parameter_can_be_a_string_in_transfor
…n_that_function_parameter_can_be_a_string_in_transfor' of https://github.com/seanjedi/pandas into SEANJEDI-49961_Docs_for_groupby_transform_should_mention_that_function_parameter_can_be_a_string_in_transfor
…ould_mention_that_function_parameter_can_be_a_string_in_transfor
…ould_mention_that_function_parameter_can_be_a_string_in_transfor
@rhshadrach Any other changes I should make? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks really good! One small request
…ould_mention_that_function_parameter_can_be_a_string_in_transfor
…ould_mention_that_function_parameter_can_be_a_string_in_transfor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, ping on green.
Thanks @seanjedi |
@mroeschke Thanks for merging it, and also sorry for the late reply, I am in grad school and this is finals week so I have been a bit busy today. |
groupby.transform()
should mention that function parameter can be a string intransform
#49961pandas/core/groupby/groupby.py