Skip to content

TST: Add test for isin for filtering with mixed types #50019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 2, 2022
Merged

TST: Add test for isin for filtering with mixed types #50019

merged 1 commit into from
Dec 2, 2022

Conversation

ltoniazzi
Copy link
Contributor

@ltoniazzi ltoniazzi commented Dec 2, 2022 •
edited
Loading

Added tests to check that .isin works as expected with different types in the series.

@ltoniazzi ltoniazzi force-pushed the add_test_isin_for_mixed_types branch from 2fe17d8 to f6726f1 Compare December 2, 2022 17:17
@ltoniazzi ltoniazzi marked this pull request as ready for review December 2, 2022 17:17
@noatamir noatamir added the Sprints Sprint Pull Requests label Dec 2, 2022
WillAyd
WillAyd requested changes Dec 2, 2022
View reviewed changes
Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks pretty good - nice job. one minor edit

@jorisvandenbossche jorisvandenbossche changed the title Add test for isin for filtering with mixed types TST: Add test for isin for filtering with mixed types Dec 2, 2022
@phofl phofl added the Testing pandas testing functions or related to the test suite label Dec 2, 2022
@ltoniazzi ltoniazzi force-pushed the add_test_isin_for_mixed_types branch from f6726f1 to 4f07414 Compare December 2, 2022 17:35
@phofl phofl added this to the 2.0 milestone Dec 2, 2022
@ltoniazzi ltoniazzi force-pushed the add_test_isin_for_mixed_types branch from 4f07414 to da36a27 Compare December 2, 2022 17:44
WillAyd
WillAyd approved these changes Dec 2, 2022
View reviewed changes
Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm when green

@jorisvandenbossche jorisvandenbossche merged commit 90757dc into pandas-dev:main Dec 2, 2022
@jorisvandenbossche
Copy link
Member

Thanks @ltoniazzi !

@ltoniazzi ltoniazzi deleted the add_test_isin_for_mixed_types branch December 5, 2022 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WillAyd WillAyd WillAyd approved these changes

@phofl phofl phofl approved these changes

Assignees
No one assigned
Labels
Sprints Sprint Pull Requests Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.

Unexpected results when filtering with .isin (some fields contain python datastructures)
5 participants
@ltoniazzi @jorisvandenbossche @WillAyd @phofl @noatamir