Skip to content

ENH: add copy on write for df reorder_levels GH49473 #50016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Dec 2, 2022

Conversation

seljaks
Copy link
Contributor

@seljaks seljaks commented Dec 2, 2022

Added copy-on-write to df.reorder_levels().

Progress towards #49473 via PyData pandas sprint.

Changed type hint because following the existing one caused an error.

@noatamir noatamir added the Sprints Sprint Pull Requests label Dec 2, 2022
Copy link
Member

@jorisvandenbossche jorisvandenbossche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good!

@phofl phofl added this to the 2.0 milestone Dec 2, 2022
@phofl
Copy link
Member

phofl commented Dec 2, 2022

Looks like there is a merge conflict. Could you resolve it?

@seljaks
Copy link
Contributor Author

seljaks commented Dec 2, 2022

Hope this resolves it.
I think the issue was that I made two branches from main and submitted two PRs that added to the same file. After the first PR got merged into main, the second caused the conflict.

@phofl
Copy link
Member

phofl commented Dec 2, 2022

Yep, thx.

@phofl phofl merged commit 474a528 into pandas-dev:main Dec 2, 2022
@phofl
Copy link
Member

phofl commented Dec 2, 2022

Thx @seljaks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants