TST/CoW: copy-on-write tests for add_prefix and add_suffix #49991
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
added
Testing
phofl
reviewed
Dec 2, 2022
| @@ -252,6 +252,47 @@ def test_set_index(using_copy_on_write): | |||
| tm.assert_frame_equal(df, df_orig) | |||
|
|
|||
|
|
|||
| def test_add_prefix(using_copy_on_write): | |||
| # Case: adding prefix returns a new dataframe | |||
There was a problem hiding this comment.
You can remove the comments, just adding the issue as reference is sufficient
phofl
approved these changes
Dec 3, 2022
|
thx @andrewchen1216 |
73 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests added and passed if fixing a bug or adding a new feature
This PR is related to #49473
add_suffixandadd_prefixalready had Copy-on-Write implemented, this PR will add test cases that explicitly tests the Copy-on-Write feature.