CLN: assorted #49979
Merged
CLN: assorted #49979
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbrockmendel
force-pushed
the
fixmes62
branch
from
e6a927a to
af7605d
Compare
WillAyd
reviewed
Dec 2, 2022
| @@ -312,7 +315,7 @@ def to_series(right): | |||
|
|
|||
|
|
|||
| def should_reindex_frame_op( | |||
| left: DataFrame, right, op, axis, default_axis, fill_value, level | |||
| left: DataFrame, right, op, axis: int, fill_value, level | |||
There was a problem hiding this comment.
Not a big deal but I guess we have AxisInt in pandas._typing for this already
There was a problem hiding this comment.
will update in next pass, dont want to futher clog the CI
mroeschke
approved these changes
Dec 6, 2022
|
LGTM merge when ready @WillAyd |
|
Thanks @jbrockmendel |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.