Skip to content

BUG: metadata does not always propagate in binary operations #49931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

MarcoGorelli
Copy link
Member

@MarcoGorelli MarcoGorelli commented Nov 27, 2022

@mroeschke mroeschke added the metadata _metadata, .attrs label Nov 28, 2022
@jbrockmendel
Copy link
Member

If this works I'm pretty sure it'll close #34373.

When we're ready to discuss deprecations for 3.0, I think we should kill off __finalize__. There's no real prospect of getting it fully-working.

@github-actions
Copy link
Contributor

This pull request is stale because it has been open for thirty days with no activity. Please update and respond to this comment if you're still interested in working on this.

@github-actions github-actions bot added the Stale label Dec 30, 2022
@MarcoGorelli
Copy link
Member Author

I'll get back to this later

When we're ready to discuss deprecations for 3.0, I think we should kill off finalize. There's no real prospect of getting it fully-working.

yeah agreed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
metadata _metadata, .attrs Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: metadata does not always propagate in binary operations
3 participants