CLN: clean core.construction._extract_index #49930
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcoGorelli
suggested changes
Nov 27, 2022
| else: | ||
| index = default_index(lengths[0]) | ||
| if have_series: | ||
| assert index is not None # for mypy |
There was a problem hiding this comment.
is the # for mypy comment still necessary?
There was a problem hiding this comment.
Good catch, the whole line is actually unnecessary as index is never None here. I'll remove it.
There was a problem hiding this comment.
😄 yeah sorry I meant the whole line
topper-123
force-pushed
the
clean_extract_index
branch
from
c0b998d to
85cb4c6
Compare
|
Updated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Return early in the case of len(data) == 0, thereby avoiding needing a long
elseclause. Also clean type hints.EDIT: The PR looks a bit messy at first sight, but it's mostly just dedenting stuff. Checking "Hide whitespace" makes the PR much clearer, as suggested by @MarcoGorelli in #49921.