Skip to content

DEPR: Change default of numeric_only to False in Resampler methods #49915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 26, 2022
Merged

DEPR: Change default of numeric_only to False in Resampler methods #49915

merged 2 commits into from
Nov 26, 2022

Conversation

rhshadrach
Copy link
Member

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

@rhshadrach rhshadrach added Resample resample method Deprecate Functionality to remove in pandas Nuisance Columns Identifying/Dropping nuisance columns in reductions, groupby.add, DataFrame.apply labels Nov 26, 2022
@rhshadrach rhshadrach added this to the 2.0 milestone Nov 26, 2022
MarcoGorelli
MarcoGorelli approved these changes Nov 26, 2022
View reviewed changes
Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks @rhshadrach !

@MarcoGorelli MarcoGorelli merged commit 16b4e53 into pandas-dev:main Nov 26, 2022
mliu08 pushed a commit to mliu08/pandas that referenced this pull request Nov 27, 2022
@rhshadrach @mliu08
DEPR: Change default of numeric_only to False in Resampler methods (p…
89c3c96 
…andas-dev#49915)

* DEPR: Change default of numeric_only to False in Resampler methods

* more cleanup
@rhshadrach rhshadrach deleted the enforce_numeric_only_resample branch November 27, 2022 14:49
@miraculixx miraculixx mentioned this pull request Oct 25, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcoGorelli MarcoGorelli MarcoGorelli approved these changes

Assignees
No one assigned
Labels
Deprecate Functionality to remove in pandas Nuisance Columns Identifying/Dropping nuisance columns in reductions, groupby.add, DataFrame.apply Resample resample method
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@rhshadrach @MarcoGorelli