Skip to content

Fix some little-endian assumptions in the tests #49913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 28, 2022
Merged

Fix some little-endian assumptions in the tests #49913

merged 1 commit into from
Nov 28, 2022

Conversation

musicinmybrain
Copy link
Contributor

See previous PR#46681.

  • closes #xxxx N/A
  • Tests added and passed if fixing a bug or adding a new feature N/A, fixes some existing test failures on s390x
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions. N/A
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature. N/A

@MarcoGorelli
Copy link
Member

can you run the pre-commit checks please?

@musicinmybrain
Copy link
Contributor Author

Long line broken and force-pushed; pre-commit passes now.

MarcoGorelli
MarcoGorelli approved these changes Nov 28, 2022
View reviewed changes
Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me

@MarcoGorelli MarcoGorelli added this to the 2.0 milestone Nov 28, 2022
@mroeschke mroeschke added the Testing pandas testing functions or related to the test suite label Nov 28, 2022
@mroeschke mroeschke merged commit ad98c2b into pandas-dev:main Nov 28, 2022
@mroeschke
Copy link
Member

Thanks @musicinmybrain

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke approved these changes

@MarcoGorelli MarcoGorelli MarcoGorelli approved these changes

Assignees
No one assigned
Labels
Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@musicinmybrain @MarcoGorelli @mroeschke