BUG: constructors #49875
Merged
BUG: constructors #49875
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WillAyd
requested changes
Nov 23, 2022
doc/source/whatsnew/v2.0.0.rst
Outdated
| @@ -747,7 +749,8 @@ Reshaping | |||
| - Bug in :func:`join` when ``left_on`` or ``right_on`` is or includes a :class:`CategoricalIndex` incorrectly raising ``AttributeError`` (:issue:`48464`) | |||
| - Bug in :meth:`DataFrame.pivot_table` raising ``ValueError`` with parameter ``margins=True`` when result is an empty :class:`DataFrame` (:issue:`49240`) | |||
| - Clarified error message in :func:`merge` when passing invalid ``validate`` option (:issue:`49417`) | |||
| - Bug in :meth:`DataFrame.explode` raising ``ValueError`` on multiple columns with ``NaN`` values or empty lists (:issue:`46084`) | |||
| - Bug in :meth:`DataFrame.explode` raising ``ValueError`` on multiple columns with ``NaN`` values or empty lists (:issue:`46084`) Bug in :meth:`DataFrame.transpose` with ``IntervalDtype`` column with ``timedelta64[ns]`` endpoints (:issue:`44917`) | |||
There was a problem hiding this comment.
Guessing this is a copy / paste error with two bugs on the same line?
There was a problem hiding this comment.
copy/paste screwup, will update.
| val = np.datetime64(1, "D") | ||
| result = DatetimeIndex([val], tz="US/Pacific") | ||
|
|
||
| expected = DatetimeIndex([val.astype("M8[s]")], tz="US/Pacific") |
There was a problem hiding this comment.
Is this actually what we expect? Any consideration to raising?
There was a problem hiding this comment.
This is correct. In 2.0 we support resolutions of "s", "ms", "us", and "ns", and when we get something that isn't one of those we cast to the closest supported reso
| @@ -53,6 +53,12 @@ | |||
|
|
|||
|
|
|||
| class TestSeriesConstructors: | |||
| def test_from_na_value_and_interval_of_datetime_dtype(self): | |||
There was a problem hiding this comment.
i dont think so. this just adds the test, the bug got fixed sometime previously
WillAyd
approved these changes
Nov 29, 2022
|
Thanks @jbrockmendel |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.