Skip to content

CI/BENCH: Make CategoricalIndexIndexing benchmark less flaky #49870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 26, 2022
Merged

CI/BENCH: Make CategoricalIndexIndexing benchmark less flaky #49870

merged 3 commits into from
Nov 26, 2022

Conversation

mroeschke
Copy link
Member

Resizing data_unique to be the same length as data which maybe is some source of flakiness since data_unique was 3x data

@mroeschke mroeschke added Unreliable Test Unit tests that occasionally fail Benchmark Performance (ASV) benchmarks labels Nov 23, 2022
MarcoGorelli
MarcoGorelli approved these changes Nov 25, 2022
View reviewed changes
Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't reproduce the flakiness locally (but have seen it fail in CI a few times), so not sure how to check whether this fixes the issue, but this does seem reasonable (not to mention more readable...)

@MarcoGorelli MarcoGorelli added this to the 2.0 milestone Nov 25, 2022
@mroeschke
Copy link
Member Author

I'll merge in main maybe 2 more times just to confirm.

@MarcoGorelli
Copy link
Member

MarcoGorelli commented Nov 25, 2022 •
edited
Loading

might be quicker to just re-run the code-checks jobs

image

@MarcoGorelli
Copy link
Member

I restarted the job and it still passed, so let's ship this, if it fails again we can revisit. Thanks @mroeschke !

@MarcoGorelli MarcoGorelli merged commit 0b47d85 into pandas-dev:main Nov 26, 2022
@mroeschke mroeschke deleted the ci/flaky_benchmark branch November 27, 2022 01:24
mliu08 pushed a commit to mliu08/pandas that referenced this pull request Nov 27, 2022
@mroeschke @mliu08
CI/BENCH: Make CategoricalIndexIndexing benchmark less flaky (pandas-…
37cb3f6 
…dev#49870)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcoGorelli MarcoGorelli MarcoGorelli approved these changes

Assignees
No one assigned
Labels
Benchmark Performance (ASV) benchmarks Unreliable Test Unit tests that occasionally fail
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@mroeschke @MarcoGorelli