CLN Simplify tz / utc arguments #49863
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcoGorelli
force-pushed
the
ref-timezones
branch
from
3f4d9a9 to
6688176
Compare
MarcoGorelli
changed the title
MarcoGorelli
force-pushed
the
ref-timezones
branch
from
6688176 to
d66b0a9
Compare
MarcoGorelli
commented
Nov 23, 2022
| tz : object | ||
| None or 'utc' | ||
| utc : bool | ||
| Whether to convert/localize timestamps to UTC. |
There was a problem hiding this comment.
here the argument was already utc, but the docstring was outdated
|
thanks @MarcoGorelli |
mliu08
pushed a commit
to mliu08/pandas
that referenced
this pull request
Nov 27, 2022
Simplify tz / utc arguments Co-authored-by: MarcoGorelli <>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.Noticed while looking into #49298
There's quite a few places where
tzcan only be'utc'orNone, which is confusing. Might as well just use the booleanutc