API: properly box numeric timedelta ops on Series (GH4984) #4985
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| # coerce float to results | ||
| if is_float(result): | ||
| result = int(result) |
There was a problem hiding this comment.
is the float value here somehow guaranteed to not have a fractional part? seems strange to just smash it to int
There was a problem hiding this comment.
ah just read your comment in the issue thread
There was a problem hiding this comment.
we'll have to revisit this in the future if a finer timescale is desired
There was a problem hiding this comment.
at worse it kills a fractional ns...and that is below our precision anyhow
|
maybe a couple small examples in |
|
yep....pusing in a second |
jreback
added a commit
that referenced
this pull request
Sep 25, 2013
API: properly box numeric timedelta ops on Series (GH4984)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #4984