Skip to content

STYLE: fix pylint redefined-outer-name warning for file #49844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Nov 23, 2022

Conversation

angularOcean
Copy link
Contributor

@angularOcean angularOcean commented Nov 22, 2022

Associated with #49656.
Fixes pylint warnings for redefined-outer-name on the following files:

pandas/core/tools/datetimes.py

@angularOcean angularOcean changed the title STYLE: fix pylint redefined-outer-name warnings STYLE: fix pylint redefined-outer-name warning for file Nov 22, 2022
@mroeschke mroeschke added the Code Style Code style, linting, code_checks label Nov 23, 2022
@MarcoGorelli
Copy link
Member

no need to keep updating the branch - this is probably fine, let's let the checks run and I'll merge later

@MarcoGorelli MarcoGorelli added this to the 2.0 milestone Nov 23, 2022
Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @angularOcean

@MarcoGorelli MarcoGorelli merged commit f74f864 into pandas-dev:main Nov 23, 2022
@angularOcean
Copy link
Contributor Author

You are welcome! Thank you for the opportunity to contribute!

mliu08 pushed a commit to mliu08/pandas that referenced this pull request Nov 27, 2022
…9844)

* addressed pylint redfined-outer-name warning in files

* addressed pylint redefined-outer-name warning in files

* addressed pylint redefined_out_name warning in datetimes.py

* addressed pylint redefined_out_name warning in datetimes.py

* updated pylint fix by renaming import timezones to libtimezones
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Style Code style, linting, code_checks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants