DEPR: Enforce numeric_only=False in groupby sum/mean #49829
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhshadrach
added
Groupby
Deprecate
|
is the failed asv time_pivot_table_margins_only_column a false-positive? |
|
Thanks @jbrockmendel - ASV failure was due to trying to take the mean of a string column; I added it to the |
mroeschke
approved these changes
Nov 23, 2022
MarcoGorelli
approved these changes
Nov 23, 2022
mliu08
pushed a commit
to mliu08/pandas
that referenced
this pull request
Nov 27, 2022
* DEPR: Enforce numeric_only=False in groupby sum/mean * cleanup * Refinements * whatsnew fixup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.Targeting these two ops first because they're used as an example op in a lot of tests. Hoping the rest of the ops are easier. Note this doesn't check off the corresponding line in the list of deprecations.