STYLE: fix pylint redefined-outer-name warnings #49822
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcoGorelli
suggested changes
Nov 21, 2022
pandas/util/_doctools.py
Outdated
| @@ -168,28 +168,28 @@ def _make_table(self, ax, df, title: str, height: float | None = None) -> None: | |||
|
|
|||
|
|
|||
| if __name__ == "__main__": | |||
| import matplotlib.pyplot as plt | |||
| import matplotlib.pyplot as pyplot | |||
There was a problem hiding this comment.
instead of renaming this (as plt is a pretty standard import), how about we put:
def main():
import matplotlib.pyplot as plt
p = TablePlotter()
<put the rest of the file here>
and then, right underneat that:
if __name__ == "__main__":
main()
|
@MarcoGorelli Addressed the requested changes in |
|
can you run the pre-commit checks? see the contributing guide for how |
Will do. |
|
@MarcoGorelli I ran the pre-commit commands. The |
MarcoGorelli
approved these changes
Nov 22, 2022
|
Glad I could help. Thanks for letting me contribute! |
mliu08
pushed a commit
to mliu08/pandas
that referenced
this pull request
Nov 27, 2022
* STYLE: fix pylint redefined-outer-name warnings * removing _test_decorators.py * Moving into a main function * pre-commit changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed
redefined-outer-namelinting issue in the following files (Towards #49656)pandas/util/_decorators.pypandas/util/_doctools.pypandas/util/_test_decorators.py