Skip to content

DEP Remove pytorch from environment.yml #49798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Nov 24, 2022
Merged

DEP Remove pytorch from environment.yml #49798

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
65675ac
no torch
Nov 20, 2022
b161041
set matplotlib to minimum version
Nov 21, 2022
6c7af59
take mpl pin out again
Nov 21, 2022
4911efc
use pip for matplotlib
Nov 21, 2022
cf4ac76
Merge remote-tracking branch 'upstream/main' into no-torch
Nov 21, 2022
4005c85
remove default channel
Nov 22, 2022
1dd83b6
no pin needed if no default channel?
Nov 22, 2022
7487adb
turns out we gotta pin
Nov 22, 2022
56e91a7
:fire: remove torch
Nov 24, 2022
212e60d
Merge remote-tracking branch 'upstream/main' into no-torch
Nov 24, 2022
96c2479
undo asv.conf.json change
Nov 24, 2022
36eb4f5
comment out pytorch
Nov 24, 2022
b8fbd12
remove commented-out torch
Nov 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions .github/workflows/code-checks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,15 +117,12 @@ jobs:
- name: Set up Conda
uses: ./.github/actions/setup-conda

- name: Build Pandas
id: build
uses: ./.github/actions/build_pandas

- name: Run ASV benchmarks
run: |
cd asv_bench
asv machine --yes
asv run --quick --dry-run --strict --durations=30 --python=same
git fetch origin main:main
asv run --quick --dry-run --strict --durations=30

build_docker_dev_environment:
name: Build Docker Dev Environment
Expand Down
3 changes: 2 additions & 1 deletion asv_bench/asv.conf.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,13 +43,14 @@
"matrix": {
"numpy": [],
"Cython": ["0.29.32"],
"matplotlib": [],
"pip+matplotlib>": ["3.6.1"],
"sqlalchemy": [],
"scipy": [],
"numba": [],
"numexpr": [],
"pytables": [null, ""], // platform dependent, see excludes below
"pyarrow": [],
"pytorch": [],
"tables": [null, ""],
"openpyxl": [],
"xlsxwriter": [],
Expand Down
1 change: 0 additions & 1 deletion environment.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,6 @@ dependencies:
- pandas-datareader
- pyyaml
- py
- pytorch

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why don't you comment it out with a note?

# local testing dependencies
- moto
Expand Down
1 change: 0 additions & 1 deletion requirements-dev.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,6 @@ coverage
pandas-datareader
pyyaml
py
torch
moto
flask
asv
Expand Down