Skip to content

update io docs for OpenDocument Spreadsheets #49792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 22, 2022

Conversation

vamsi-verma-s
Copy link
Contributor

@rhshadrach rhshadrach added the IO Excel read_excel, to_excel label Nov 20, 2022
@rhshadrach rhshadrach added this to the 2.0 milestone Nov 20, 2022
Copy link
Member

@rhshadrach rhshadrach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@attack68
Copy link
Contributor

I believe this documentation is shared by Styler.to_excel. Can I ask double check if this write mode also supports that output method including the addition of excel colors, number formats and borders? etc.

@rhshadrach
Copy link
Member

@attack68 - not sure what you mean by "shared" here; is it that the Styler.to_excel docs link to this section of the documentation? I checked and that doesn't seem to be the case (but I might be missing it?).

@attack68
Copy link
Contributor

I am of the understanding that there is no direct documentation for Styler.to_excel it is a shared substitution of DataFrame.to_excel.

    @doc(
        NDFrame.to_excel,
        klass="Styler",
        storage_options=_shared_docs["storage_options"],
        storage_options_versionadded="1.5.0",
    )

Therefore I wonder if this update to those docs will automatically apply to Styler.to_excel and if the alternative render engine can correctly parse styles. Lot of ifs, but worth the question.

@rhshadrach
Copy link
Member

This isn't an update to the doc strings, it's an update to the User Guide here: https://pandas.pydata.org/pandas-docs/dev/user_guide/io.html#opendocument-spreadsheets

@attack68
Copy link
Contributor

great. my bad, thx for highlighting.

@mroeschke mroeschke merged commit 3e7cd5e into pandas-dev:main Nov 22, 2022
@mroeschke
Copy link
Member

Thanks @vamsi-verma-s

mliu08 pushed a commit to mliu08/pandas that referenced this pull request Nov 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
IO Excel read_excel, to_excel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DOC: to_excel OpenDocument Spreadsheets (ODS) write support not updated
4 participants