STYLE enable pylint: confusing-with-statement #49789
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pandas/tests/io/test_pickle.py
Outdated
Comment on lines
286
to
287
| with open(src_path, "rb") as fh, f: | ||
| with open(src_path, "rb") as fh: | ||
| f.write(fh.read()) |
There was a problem hiding this comment.
does it work to nest the with statements? like
with open(src_path, 'rb') as fh:
with f:
f.write(fh.read())?
There was a problem hiding this comment.
Thanks, @MarcoGorelli, it works like a charm. I updated the commit.
MarcoGorelli
approved these changes
Nov 19, 2022
| @@ -352,7 +353,6 @@ def test_read_explicit(self, compression, get_random_path): | |||
|
|
|||
| # read compressed file | |||
| df2 = pd.read_pickle(p2, compression=compression) | |||
|
|
|||
There was a problem hiding this comment.
for the future, it's better to not delete unrelated lines, but it's fine here
mliu08
pushed a commit
to mliu08/pandas
that referenced
this pull request
Nov 27, 2022
* STYLE enable pylint: confusing-with-statement * STYLE enable pylint: confusing-with-statement II
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #48855. This PR enables pylint type "W" warning:
confusing-with-statementAfter fixing the warning
confusing-with-statementrunningpandas/tests/io/test_pickle.pyraises an errorEOFError: Ran out of input. To handle this error I check if the size of the file is not zero. Maybe there is a better way to deal with the test?