Skip to content

CI: Limit pip extras check to Build tag #49778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 23, 2022
Merged

CI: Limit pip extras check to Build tag #49778

merged 3 commits into from
Nov 23, 2022

Conversation

mroeschke
Copy link
Member

@mroeschke mroeschke added the CI Continuous Integration label Nov 18, 2022
@lithomas1 lithomas1 added Build Library building on various platforms and removed Build Library building on various platforms labels Nov 18, 2022
@lithomas1
Copy link
Member

This doesn't seem to be triggering, but the logic looks correct to me(pretty sure its identical to the working sdist trigger).

I'll try again later, we might be hitting some sort of concurrency limit.

@lithomas1 lithomas1 added Build Library building on various platforms and removed Build Library building on various platforms labels Nov 19, 2022
@lithomas1
Copy link
Member

Oh, I figured it out. You need to add "labeled" to the "on" tag like https://github.com/pandas-dev/pandas/blob/main/.github/workflows/sdist.yml#L12, for the labelling to trigger the runs.

@mroeschke
Copy link
Member Author

Oh, I figured it out. You need to add "labeled" to the "on" tag like https://github.com/pandas-dev/pandas/blob/main/.github/workflows/sdist.yml#L12, for the labelling to trigger the runs.

Ah cool thanks. Added the on tags to the workflow

@mroeschke mroeschke added this to the 2.0 milestone Nov 22, 2022
@lithomas1 lithomas1 merged commit c7460e5 into pandas-dev:main Nov 23, 2022
@lithomas1
Copy link
Member

Thanks @mroeschke.

@mroeschke mroeschke deleted the ci/limit_package_check branch November 23, 2022 02:36
mliu08 pushed a commit to mliu08/pandas that referenced this pull request Nov 27, 2022
@mroeschke @mliu08
CI: Limit pip extras check to Build tag (pandas-dev#49778)
f97eaf2 
* CI: Limit pip extras check to Build tag

* add on tags
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lithomas1 lithomas1 lithomas1 approved these changes

Assignees
No one assigned
Labels
Build Library building on various platforms CI Continuous Integration
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@mroeschke @lithomas1