-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
STYLE: fixing linting issues (redefined-outer-name) #49762
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
MarcoGorelli
merged 10 commits into
pandas-dev:main
from
seanjedi:seanjedi-49724_pylint's_redefined_outer_name
Nov 22, 2022
Merged
STYLE: fixing linting issues (redefined-outer-name) #49762
MarcoGorelli
merged 10 commits into
pandas-dev:main
from
seanjedi:seanjedi-49724_pylint's_redefined_outer_name
Nov 22, 2022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixing pylint issues in xml.py, style.py, and _json.py
This code causes the tests to fail, will need to troubleshoot why. |
MarcoGorelli
suggested changes
Nov 18, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is off to a good start, I've left some comments
Fixing the PR checks failing test cases for my PR
MarcoGorelli
suggested changes
Nov 19, 2022
MarcoGorelli
approved these changes
Nov 22, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @seanjedi !
mliu08
pushed a commit
to mliu08/pandas
that referenced
this pull request
Nov 27, 2022
* fix: fixing linting issues Fixing pylint issues in xml.py, style.py, and _json.py * fix: fixing issue with some failing test cases Fixing the PR checks failing test cases for my PR * fix: fixing styling issues and PR comments * fix: removing some code not necessary for PR * fx: updating my code to be better formatted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing pylint issues in xml.py, style.py, and _json.py
doc/source/whatsnew/vX.X.X.rst
file if fixing a bug or adding a new feature.I am a new contributor to Pandas, and still learning the ropes, I apologize ahead of time for making any rookie mistakes. Any advice would be highly appreciated!