Skip to content

STYLE: fixing linting issues (redefined-outer-name) #49762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

seanjedi
Copy link
Contributor

@seanjedi seanjedi commented Nov 18, 2022

Fixing pylint issues in xml.py, style.py, and _json.py

I am a new contributor to Pandas, and still learning the ropes, I apologize ahead of time for making any rookie mistakes. Any advice would be highly appreciated!

Fixing pylint issues in xml.py, style.py, and _json.py
@MarcoGorelli MarcoGorelli changed the title STYLE: fixing linting issues STYLE: fixing linting issues (redefined-outer-name) Nov 18, 2022
@seanjedi
Copy link
Contributor Author

This code causes the tests to fail, will need to troubleshoot why.

Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is off to a good start, I've left some comments

@mroeschke mroeschke added the Code Style Code style, linting, code_checks label Nov 18, 2022
Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @seanjedi !

@MarcoGorelli MarcoGorelli added this to the 2.0 milestone Nov 22, 2022
@MarcoGorelli MarcoGorelli merged commit 22de537 into pandas-dev:main Nov 22, 2022
@seanjedi seanjedi deleted the seanjedi-49724_pylint's_redefined_outer_name branch November 22, 2022 22:17
@seanjedi seanjedi restored the seanjedi-49724_pylint's_redefined_outer_name branch November 22, 2022 22:35
mliu08 pushed a commit to mliu08/pandas that referenced this pull request Nov 27, 2022
* fix: fixing linting issues
Fixing pylint issues in xml.py, style.py, and _json.py

* fix: fixing issue with some failing test cases
Fixing the PR checks failing test cases for my PR

* fix: fixing styling issues and PR comments

* fix: removing some code not necessary for PR

* fx: updating my code to be better formatted
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Style Code style, linting, code_checks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants