CLN: Testing and unused #49754
Merged
CLN: Testing and unused #49754
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
added
Testing
MarcoGorelli
approved these changes
Nov 17, 2022
| @pytest.mark.parametrize("keep", ["first", "last", False]) | ||
| def test_drop_duplicates_series_vs_dataframe(keep): |
There was a problem hiding this comment.
cause this is the same as the fixture? 🤔 might be an idea for an automated test
There was a problem hiding this comment.
Yup same as this one
Lines 304 to 310 in cca262d
Yeah it would be great to have a check to answer "Does a @pytest.mark.parametrize return the same params as an existing fixture"
Comment on lines
-492
to
+453
| def test_maybe_promote_string_with_any(string_dtype, any_numpy_dtype_reduced): | ||
| def test_maybe_promote_string_with_any(string_dtype, any_numpy_dtype): |
There was a problem hiding this comment.
is the idea here just that any_numpy_dtype is a superset of any_numpy_dtype_reduced, and that one might as well test over the larger set?
MarcoGorelli
pushed a commit
to MarcoGorelli/pandas
that referenced
this pull request
Nov 18, 2022
* Remove unused rand_bools * Remove references to append * Reuse existing fixtures * Replace another top level fixture
mliu08
pushed a commit
to mliu08/pandas
that referenced
this pull request
Nov 27, 2022
* Remove unused rand_bools * Remove references to append * Reuse existing fixtures * Replace another top level fixture
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
appendrandboolpandas/conftest.py