BUG: parsing ISO8601 string with format= and timezone name fails
#49747
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcoGorelli
changed the title
format= and timezone name fails
MarcoGorelli
commented
Nov 17, 2022
| @@ -1755,7 +1755,6 @@ def test_to_datetime_iso8601(self, cache, arg, exp_str): | |||
| ("2012-01-01 10", "%Y-%m-%d %H:%M"), | |||
| ("2012-01-01 10:00", "%Y-%m-%d %H:%M:%S"), | |||
| ("2012-01-01 10:00:00", "%Y-%m-%d %H:%M:%S.%f"), | |||
| ("2012-01-01 10:00:00.123", "%Y-%m-%d %H:%M:%S.%f%Z"), | |||
There was a problem hiding this comment.
this one no longer goes down the ISO8601 fastpath, so removing it from here
| @@ -284,10 +284,10 @@ def test_parse_time_string_check_instance_type_raise_exception(): | |||
| ("%Y%m%d %H:%M:%S", True), | |||
| ("%Y-%m-%dT%H:%M:%S", True), | |||
| ("%Y-%m-%dT%H:%M:%S%z", True), | |||
| ("%Y-%m-%dT%H:%M:%S%Z", True), | |||
| ("%Y-%m-%dT%H:%M:%S%Z", False), | |||
There was a problem hiding this comment.
these are no longer detected as ISO because the pandas ISO8601 fastpath can't handle them
mroeschke
reviewed
Nov 17, 2022
mroeschke
approved these changes
Nov 17, 2022
|
thanks for reviewing! |
MarcoGorelli
added a commit
to MarcoGorelli/pandas
that referenced
this pull request
Nov 18, 2022
…andas-dev#49747) * %z -> %Z * add whatsnew note and regression test Co-authored-by: MarcoGorelli <>
mliu08
pushed a commit
to mliu08/pandas
that referenced
this pull request
Nov 27, 2022
…andas-dev#49747) * %z -> %Z * add whatsnew note and regression test Co-authored-by: MarcoGorelli <>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
format=and timezone name fails #49748doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.