-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
Revert "Add 'color' and 'size' to arguments (#44856)" #49734
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This reverts commit 8a4abfa. # Conflicts: # doc/source/whatsnew/v1.5.0.rst # pandas/plotting/_core.py # pandas/tests/plotting/frame/test_frame_color.py
yeah should be fine 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. @MarcoGorelli merge when ready
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome thanks @phofl
Oops, something went wrong applying the patch ... Please have a look at my logs. |
@meeseeksdev backport 1.5.x |
Oops, something went wrong applying the patch ... Please have a look at my logs. |
don't know what's up with meeseeksdev, but I've done this manually in #49752 |
…as-dev#49734) * Revert "Add 'color' and 'size' to arguments (pandas-dev#44856)" This reverts commit 8a4abfa. # Conflicts: # doc/source/whatsnew/v1.5.0.rst # pandas/plotting/_core.py # pandas/tests/plotting/frame/test_frame_color.py * Add whatsnew
…as-dev#49734) * Revert "Add 'color' and 'size' to arguments (pandas-dev#44856)" This reverts commit 8a4abfa. # Conflicts: # doc/source/whatsnew/v1.5.0.rst # pandas/plotting/_core.py # pandas/tests/plotting/frame/test_frame_color.py * Add whatsnew
doc/source/whatsnew/vX.X.X.rst
file if fixing a bug or adding a new feature.cc @MarcoGorelli would you be ok with reverting?