ENH: DatetimeProperties results seem to be inconsistent since missing milliseconds #49073 #49719
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
reviewed
Nov 16, 2022
| @@ -1874,6 +1898,7 @@ def to_julian_date(self) -> npt.NDArray[np.float64]: | |||
| self.hour | |||
| + self.minute / 60 | |||
| + self.second / 3600 | |||
| + self.millisecond / 3600 / 10**3 | |||
There was a problem hiding this comment.
Why was this added? I think self.microsecond should already include the milliseconds
mroeschke
requested changes
Nov 16, 2022
|
closing as per #49073 (comment) , but thanks for your PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DatetimePropertiesresults seem to be inconsistent since missing milliseconds #49073 (Replace xxxx with the GitHub issue number)I have added the millisecond feature to the Datetime function on Pandas. As it was discussed in the issue, it seemed inconsistent. However, I didn't change how the microseconds were being exhibited (with 6 digits instead of 3), not to break the code.