-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
ENH: dont guess %Y/%m #49711
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: dont guess %Y/%m #49711
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just curious, is the intent to eventually only guess formats that are ISO compliant? I think removing this functionality is okay if we can justify (document) to the user why
The goal would still be to guess most date formats, especially non-ISO8601 ones It's just for dates which don't have all three of "year, month, and day" that perhaps it's better to not guess (unless they're ISO8601), cc @WillAyd |
Yea I think adhering to ISO for inference is going to be the easiest to develop / communicate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay since this is kind of an edge case I am okay with this then as long as it's stated somewhere (in this or a following PR) that some prior formats are no longer guessed since they were not ISO
Thanks @MarcoGorelli |
Follow-up from #49389
Guess "year month", but only if it's "%Y-%m" as that's ISO8601 compliant