BUG: SparseArray.astype(np.int64) #49704
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
added
Dtype Conversions
mroeschke
reviewed
Nov 16, 2022
| dtype = cast(ExtensionDtype, dtype) | ||
| cls = dtype.construct_array_type() | ||
| return cls._from_sequence(self, dtype=dtype, copy=copy) | ||
| values = np.asarray(self) |
There was a problem hiding this comment.
Is this robust if the original type was pd.SparseDtype(pd.Int64Dtype) with an NA and astype(pd.Int32Dtype) was called?
There was a problem hiding this comment.
Oh looks like there an existing bug here too (missing import)
In [1]: arr = pd.array([1, pd.NA], dtype=pd.SparseDtype(pd.Int64Dtype()))
In [2]: arr
Out[2]:
[1, <NA>]
Fill: <NA>
IntIndex
Indices: array([0], dtype=int32)
In [3]: arr.dtype
Out[3]: Sparse[Int64, <NA>]
In [4]: arr.astype(pd.Int16Dtype())
NameError: name 'ExtensionDtype' is not defined
There was a problem hiding this comment.
yah, though i think that was introduced by a pylint PR really recently. updatenope it was introduced by me 15 days ago
also IIUC pd.SparseDtype(EADtype) shouldn't work.
There was a problem hiding this comment.
Could you raise a NotImplementedError for the EADtypes here for now then?
There was a problem hiding this comment.
id rather do that as separately to Do It Right along with a couple other bugs mentioned in #49631
mroeschke
approved these changes
Nov 17, 2022
|
Thanks @jbrockmendel |
MarcoGorelli
pushed a commit
to MarcoGorelli/pandas
that referenced
this pull request
Nov 18, 2022
* BUG: SparseArray.astype(np.int64) * whatsnew
mliu08
pushed a commit
to mliu08/pandas
that referenced
this pull request
Nov 27, 2022
* BUG: SparseArray.astype(np.int64) * whatsnew
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.