Skip to content

BUG: support ambiguous=infer with ZoneInfo #49700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Nov 23, 2022
Merged

BUG: support ambiguous=infer with ZoneInfo #49700

merged 7 commits into from
Nov 23, 2022

Conversation

jbrockmendel
Copy link
Member

@jbrockmendel jbrockmendel commented Nov 14, 2022 •
edited
Loading

Sits on top of #49684

@mroeschke mroeschke added the Timezones Timezone data dtype label Nov 16, 2022
@mroeschke
Copy link
Member

mroeschke commented Nov 16, 2022 •
edited
Loading

Fixes #48442? (and therefore this change is/should be considered for backporting)

@jbrockmendel
Copy link
Member Author

Fixes #48442? (and therefore this change is/should be considered for backporting)

yes

mroeschke
mroeschke approved these changes Nov 23, 2022
View reviewed changes
Copy link
Member

@mroeschke mroeschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Related side question, do we have testing tz_localize/convert with the nonexistent options?

@mroeschke mroeschke added this to the 2.0 milestone Nov 23, 2022
@jbrockmendel
Copy link
Member Author

do we have testing tz_localize/convert with the nonexistent options?

you mean specific to ZoneInfo? i dont think so. would be straightforward to add ZoneInfo case to test_tz_localize_nonexistent since it is currently parametrized over pytz/dateutil

@mroeschke
Copy link
Member

do we have testing tz_localize/convert with the nonexistent options?

you mean specific to ZoneInfo? i dont think so. would be straightforward to add ZoneInfo case to test_tz_localize_nonexistent since it is currently parametrized over pytz/dateutil

Correct, yes if these can be added in a follow up that would be good.

@mroeschke mroeschke merged commit 50a8667 into pandas-dev:main Nov 23, 2022
@jbrockmendel jbrockmendel deleted the enh-ambiguous-zoneinfo branch November 23, 2022 19:25
@jbrockmendel
Copy link
Member Author

good call on checking this; ATM this segfaults

mliu08 pushed a commit to mliu08/pandas that referenced this pull request Nov 27, 2022
@jbrockmendel @mliu08
BUG: support ambiguous=infer with ZoneInfo (pandas-dev#49700)
351728e 
* BUG: rendering dt64tz values with non-pytz

* GH ref

* py38 compat

* BUG: support ambiguous=infer with ZoneInfo

* add type declaration

* no-tzdata compat
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke approved these changes

Assignees
No one assigned
Labels
Timezones Timezone data dtype
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.

BUG: Series.dt.tz_localize not recognizing DST transition with zoneinfo timezone when ambiguous="infer"
2 participants
@jbrockmendel @mroeschke