TYP: MergeHow + JoinHow #49664
Merged
TYP: MergeHow + JoinHow #49664
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phofl
reviewed
Nov 16, 2022
| MergeHow = Literal["left", "right", "inner", "outer", "cross"] | ||
|
|
||
| # join | ||
| JoinHow = Literal["left", "right", "inner", "outer"] |
There was a problem hiding this comment.
typed join with MergeHow.. used JoinHow for the indices.
I actually took this from pandas-stubs
There was a problem hiding this comment.
Could you check how they type DataFrame.join?
There was a problem hiding this comment.
they've used JoinHow.. i guess that would also require correction?
phofl
approved these changes
Dec 5, 2022
|
thx @debnathshoham |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.merge- specify string literals for.mergehowkeyword #48503doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.