STYLE: fix pylint redefined-outer-name warnings (#49656) #49662
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcoGorelli
suggested changes
Nov 12, 2022
grtcoder
force-pushed
the
enable_pylint
branch
2 times, most recently
from
a5eea36 to
1ec48f4
Compare
Fixed warnings for the following files :- - pandas/core/arrays/datetimelike.py - pandas/core/base.py - pandas/core/computation/pytables.py
grtcoder
force-pushed
the
enable_pylint
branch
from
1ec48f4 to
5f906e5
Compare
|
I have amended the commit in the base branch. Is that usually the workflow, or do people prefer separate commits for iterations? |
MarcoGorelli
suggested changes
Nov 13, 2022
Fixed warnings for the following files :- - pandas/core/arrays/datetimelike.py - pandas/core/base.py - pandas/core/computation/pytables.py Iteration :- 2
mliu08
pushed a commit
to mliu08/pandas
that referenced
this pull request
Nov 27, 2022
…andas-dev#49662) * STYLE: fix pylint redefined-outer-name warnings (pandas-dev#49656) Fixed warnings for the following files :- - pandas/core/arrays/datetimelike.py - pandas/core/base.py - pandas/core/computation/pytables.py * STYLE: fix pylint redefined-outer-name warnings (pandas-dev#49656) Fixed warnings for the following files :- - pandas/core/arrays/datetimelike.py - pandas/core/base.py - pandas/core/computation/pytables.py Iteration :- 2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed warnings for the following files :-
pandas/core/arrays/datetimelike.py
pandas/core/base.py
pandas/core/computation/pytables.py
Tests added and passed if fixing a bug or adding a new feature
All code checks passed.
Added type annotations to new arguments/methods/functions.
Added an entry in the latest
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.