REF: share astype exception messages #49655
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
reviewed
Nov 16, 2022
| # invalid input to is_bool_dtype | ||
| pass | ||
| if is_bool_dtype(cast_type): | ||
| raise ValueError(f"Bool column has NA values in column {c}") |
There was a problem hiding this comment.
So are there new user-facing paths where this is raised now?
There was a problem hiding this comment.
not AFAICT. the except (AttributeError, TypeError): this removes should be un-reachable
mroeschke
approved these changes
Nov 16, 2022
|
Thanks @jbrockmendel |
MarcoGorelli
pushed a commit
to MarcoGorelli/pandas
that referenced
this pull request
Nov 18, 2022
* REF: share astype exception messages * mypy fixup
mliu08
pushed a commit
to mliu08/pandas
that referenced
this pull request
Nov 27, 2022
* REF: share astype exception messages * mypy fixup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.