Skip to content

STYLE: fix pylint reimported warnings #49645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 11, 2022
Merged

STYLE: fix pylint reimported warnings #49645

merged 2 commits into from
Nov 11, 2022

Conversation

Moisan
Copy link
Contributor

@Moisan Moisan commented Nov 11, 2022

Related to #48855

MarcoGorelli
MarcoGorelli approved these changes Nov 11, 2022
View reviewed changes
Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @Moisan , looks good to me pending green

(related, we should probably make a check that standardlibrary imports are always at the top of the file)

@MarcoGorelli MarcoGorelli added the Code Style Code style, linting, code_checks label Nov 11, 2022
@MarcoGorelli MarcoGorelli added this to the 2.0 milestone Nov 11, 2022
@MarcoGorelli MarcoGorelli mentioned this pull request Nov 11, 2022
Closed
@Moisan
Copy link
Contributor Author

Moisan commented Nov 11, 2022 •
edited
Loading

(related, we should probably make a check that standardlibrary imports are always at the top of the file)

I believe isort already covers this with the pyproject.toml config:

sections = ["FUTURE", "STDLIB", "THIRDPARTY" ,"PRE_LIBS" , "PRE_CORE", "DTYPES", "FIRSTPARTY", "POST_CORE", "LOCALFOLDER"]

@MarcoGorelli
Copy link
Member

isort just checks the order, rather than where imports are

@MarcoGorelli MarcoGorelli merged commit 289f32d into pandas-dev:main Nov 11, 2022
@Moisan Moisan deleted the pylint-reimported branch November 12, 2022 00:53
codamuse pushed a commit to codamuse/pandas that referenced this pull request Nov 12, 2022
@Moisan @codamuse
STYLE: fix pylint reimported warnings (pandas-dev#49645)
0541b89 
* STYLE: fix pylint reimported warnings

* fixup! STYLE: fix pylint reimported warnings
mliu08 pushed a commit to mliu08/pandas that referenced this pull request Nov 27, 2022
@Moisan @mliu08
STYLE: fix pylint reimported warnings (pandas-dev#49645)
a7b4f0b 
* STYLE: fix pylint reimported warnings

* fixup! STYLE: fix pylint reimported warnings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcoGorelli MarcoGorelli MarcoGorelli approved these changes

Assignees
No one assigned
Labels
Code Style Code style, linting, code_checks
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Moisan @MarcoGorelli