BUG: groupby.describe with as_index=False incorrect #49643
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhshadrach
added
Bug
Groupby
Apply
mroeschke
reviewed
Nov 16, 2022
mroeschke
reviewed
Nov 16, 2022
There is now 😄. Added for Series and DataFrame. There are tests for multiple groupings, but I think all cases were not in-axis, so made sense to add these too. |
mroeschke
approved these changes
Nov 18, 2022
|
Nice thanks @rhshadrach (the groupby describe output looks more sane now) |
MarcoGorelli
pushed a commit
to MarcoGorelli/pandas
that referenced
this pull request
Nov 18, 2022
* BUG: groupby.describe with as_index=False incorrect * Add test for two groupings * Simplify logic
mliu08
pushed a commit
to mliu08/pandas
that referenced
this pull request
Nov 27, 2022
* BUG: groupby.describe with as_index=False incorrect * Add test for two groupings * Simplify logic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.The describe bug was found while comparing differences between
_selected_objand_obj_with_exclusions(#46944). By removingas_indexfrom the conditions that determine_selected_obj, we fix the describe bug, the apply inconsistency (see below), and bring_selected_objand_obj_with_exclusionscloser so that the latter can eventually be removed.Currently
groupby(...).applywithas_index=Truewill try to use the group keys, then if that fails with a TypeError will try to redo the computation without the group keys. In main, this is also attempted whenas_index=False, however in that case the selection context does not exclude the group keys and so it's really just attempting the same exact computation again. This PR fixes this inconsistency by makingas_index=Falseadopt theas_index=Truebehavior. In the one test that picked this up, we now agree with the original behavior that was desired in #7002.