Skip to content

DOC: Gitpod documentation #49642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jan 9, 2023
Merged

DOC: Gitpod documentation #49642

merged 10 commits into from
Jan 9, 2023

Conversation

noatamir
Copy link
Member

@noatamir noatamir commented Nov 11, 2022

xref #48107

Documentation for using the development Gitpod.

@noatamir
Copy link
Member Author

I got some warning about the title capitalization in pre-commit. But it was relating to Gitpod and Liveserve, and words after the colon, which I wasn't use about the style guide there. Is that a problem? What's your recommendation here? I would prefer the brands to be capitalized in the titles.

@jorisvandenbossche
Copy link
Member

For the capitalization, there is a list of exceptions that get ignored here:

CAPITALIZATION_EXCEPTIONS = {

@mroeschke mroeschke added the Docs label Nov 16, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jan 2, 2023

This pull request is stale because it has been open for thirty days with no activity. Please update and respond to this comment if you're still interested in working on this.

@github-actions github-actions bot added the Stale label Jan 2, 2023
@noatamir
Copy link
Member Author

noatamir commented Jan 6, 2023

@jorisvandenbossche current pre-commit errors are about changing "I" or "I'm" in headlines to lower case "i".
Should I need to add those to the capitalization script as well?

@noatamir noatamir marked this pull request as ready for review January 6, 2023 16:38
@noatamir noatamir changed the title DOC: Gitpod documentation (WiP) DOC: Gitpod documentation Jan 6, 2023
@noatamir noatamir requested a review from phofl January 6, 2023 16:40
@phofl
Copy link
Member

phofl commented Jan 7, 2023

I think it makes sense to add I as an exception

@phofl phofl added this to the 2.0 milestone Jan 8, 2023
@phofl phofl removed the Stale label Jan 8, 2023
@phofl
Copy link
Member

phofl commented Jan 9, 2023

Merging, we have a sprint tomorrow and would like to reference to this.

Please ping with suggestions, if we should improve anything

@phofl phofl merged commit d7714cd into pandas-dev:main Jan 9, 2023
@phofl
Copy link
Member

phofl commented Jan 9, 2023

thx @noatamir

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants