Skip to content

STYLE: fix pylint useless-else-on-loop warnings #49595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 9, 2022
Merged

STYLE: fix pylint useless-else-on-loop warnings #49595

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions pandas/core/internals/array_manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -697,8 +697,7 @@ def _equal_values(self, other) -> bool:
for left, right in zip(self.arrays, other.arrays):
if not array_equals(left, right):
return False
else:
return True
return True

# TODO
# to_dict
Expand Down
1 change: 0 additions & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,6 @@ disable = [
"unused-import",
"unused-variable",
"using-constant-test",
"useless-else-on-loop",
"useless-parent-delegation"
]

Expand Down
3 changes: 1 addition & 2 deletions scripts/sync_flake8_versions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,8 +55,7 @@ def _get_repo_hook(repos: Sequence[Repo], hook_name: str) -> tuple[Repo, YamlMap
for hook in repo["hooks"]:
if hook["id"] == hook_name:
return repo, hook
else: # pragma: no cover
raise RuntimeError(f"Repo with hook {hook_name} not found")
raise RuntimeError(f"Repo with hook {hook_name} not found") # pragma: no cover


def _conda_to_pip_compat(dep):
Expand Down