CLN: collect fastpath in Series.__init__ #49575
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
topper-123
commented
Nov 8, 2022
| # skips validation of the name | ||
| object.__setattr__(self, "_name", name) | ||
| NDFrame.__init__(self, data) | ||
| return |
There was a problem hiding this comment.
fastpath now ends here and everything below can simply be moved one level to the left.
|
The failed check seems unrelated. |
mroeschke
reviewed
Nov 8, 2022
| @@ -378,103 +377,99 @@ def __init__( | |||
| data = SingleArrayManager.from_array(data, index) | |||
| if copy: | |||
| data = data.copy() | |||
| if index is None: | |||
There was a problem hiding this comment.
Why is this if index is None: check no longer needed in the fastpath?
There was a problem hiding this comment.
If you follow the code all the way down to the end of the method you can see that this actually is a noop; It's superflous code and can be removed. It was just difficult to see in the old code.
mroeschke
approved these changes
Nov 9, 2022
|
Thanks @topper-123 |
phofl
pushed a commit
to phofl/pandas
that referenced
this pull request
Nov 9, 2022
* CLN: collect fastpath in Series.__init__ * small clean Co-authored-by: Terji Petersen <[email protected]>
codamuse
pushed a commit
to codamuse/pandas
that referenced
this pull request
Nov 12, 2022
* CLN: collect fastpath in Series.__init__ * small clean Co-authored-by: Terji Petersen <[email protected]>
mliu08
pushed a commit
to mliu08/pandas
that referenced
this pull request
Nov 27, 2022
* CLN: collect fastpath in Series.__init__ * small clean Co-authored-by: Terji Petersen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Collect fastpath functionality in one place simplifies implementation